-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interaction Gating #1561
Merged
Merged
Interaction Gating #1561
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
d7ee9f3
lexicons for block lists
devinivy a21aa90
reorg blockset functionality into graph service, impl block/mute filt…
devinivy 1a5eae2
apply filterBlocksAndMutes() throughout appview except feeds
devinivy 15d1220
update local feeds to pass through cleanFeedSkeleton(), offload block…
devinivy b194a58
impl for grabbing block/mute details by did pair
devinivy 0dc8413
refactor getActorInfos away, use actor service
devinivy c6385f1
Merge remote-tracking branch 'origin/main' into block-lists-redux-redux
devinivy d571bfe
experiment with moving getFeedGenerators over to a pipeline
devinivy 890c9fc
move getPostThread over to a pipeline
devinivy 57fbaa2
move feeds over to pipelines
devinivy 6712b2e
move suggestions and likes over to pipelines
devinivy b550d1d
move reposted-by, follows, followers over to pipelines, tidy author f…
devinivy 4f4580c
remove old block/mute checks
devinivy 9801663
unify post presentation logic
devinivy 2a1eced
move profiles endpoints over to pipelines
devinivy 8a72f5a
tidy
devinivy e5b51c2
tidy
devinivy 541c6c0
Merge remote-tracking branch 'origin/main' into block-lists-redux-redux
devinivy 7ab70f9
Merge remote-tracking branch 'origin/block-lists-redux-redux' into bl…
devinivy cdcc26b
misc fixes
devinivy 992c25f
unify some profile hydration/presentation in appview
devinivy da221b0
profile detail, split hydration and presentation, misc fixes
devinivy a353624
unify feed hydration w/ profile hydration
devinivy 0015729
unify hydration step for embeds, tidy application of labels
devinivy 32f826e
setup indexing of list-blocks in bsky appview
devinivy ec21246
apply list-blocks, impl getListBlocks, tidy getList, tests
devinivy eb30fd1
tidy
devinivy 8711f6c
update pds proxy snaps
devinivy a27b532
Merge remote-tracking branch 'origin/block-lists-redux-redux-pipeline…
devinivy 0265e49
update pds proxy snaps
devinivy 280eb5a
fix snap
devinivy 0dfa73b
make algos return feed items, save work in getFeed
devinivy 0259785
misc changes, tidy
devinivy c84bc28
tidy
devinivy c645ed7
Merge pull request #1547 from bluesky-social/block-lists-redux-redux-…
devinivy d01ae4a
Merge remote-tracking branch 'origin/block-lists-redux-redux' into bl…
devinivy d704510
Merge branch 'main' into block-lists-redux-redux
dholms f4918c8
Merge pull request #1549 from bluesky-social/block-lists-redux-redux-…
devinivy 447d7a5
fix aturi import
devinivy 2a8e48b
initial lexicons for interaction-gating
devinivy 9b7743c
add interactions view to post views
devinivy a910034
codegen
devinivy 1656335
model bad reply/interaction check state on posts
devinivy e916b5c
initial impl for checking bad reply or interaction on write
devinivy 3eb6e63
omit invalid interactions from post thread
devinivy 0e560ea
support not-found list in interaction view
devinivy aec42a2
hydrate can-reply state on threads
devinivy e3cf14d
present interaction views on posts
devinivy cea6ff0
misc fixes, update snaps
devinivy aa49fbb
tidy/reorg
devinivy 04c738f
tidy
devinivy d7c6dce
split interaction gating into separate record in lexicon
devinivy 9e74667
switch interaction-gating impl to use separate record type
devinivy 76cc20d
allow checking reply gate w/ root post deletion
devinivy 8d6e0b4
fix
devinivy 29b5ebb
initial gating tests
devinivy 0ab206e
tighten gated reply views, tests
devinivy 50b1875
reply-gating list rule tests
devinivy f0133f2
allow custom post rkeys within window
devinivy 642f975
Merge remote-tracking branch 'origin/main' into block-lists-redux-redux
devinivy 0535368
hoist actors out of composeThread()
devinivy cb30cff
tidy
devinivy 31a7306
Merge remote-tracking branch 'origin/block-lists-redux-redux' into in…
devinivy c2740a3
update thread gate lexicons, codegen
devinivy 25fc209
lex fix
devinivy b94477c
rename gate to threadgate in bsky, update views
devinivy 52b5972
lex fix
devinivy 60bbeb6
improve terminology around reply validation
devinivy 6a8eaba
fix down migration
devinivy 30ca7f0
remove thread gates on actor unindexing
devinivy cd54186
add back .prettierignore
devinivy edee5a6
tidy
devinivy d11ecd8
run ci on all prs
dholms 5218ab9
syntax
dholms 51cd347
run ci on all prs
dholms bd6a7a6
Merge branch 'block-lists-redux-redux' into interaction-gating-init
dholms 79cb410
format
dholms 1f852b2
merge main
dholms d6bdcab
fix snap
dholms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
{ | ||
"lexicon": 1, | ||
"id": "app.bsky.feed.threadgate", | ||
"defs": { | ||
"main": { | ||
"type": "record", | ||
"key": "tid", | ||
"description": "Defines interaction gating rules for a thread. The rkey of the threadgate record should match the rkey of the thread's root post.", | ||
"record": { | ||
"type": "object", | ||
"required": ["post", "createdAt"], | ||
"properties": { | ||
"post": { "type": "string", "format": "at-uri" }, | ||
"allow": { | ||
"type": "array", | ||
"maxLength": 5, | ||
"items": { | ||
"type": "union", | ||
"refs": ["#mentionRule", "#followingRule", "#listRule"] | ||
} | ||
}, | ||
"createdAt": { "type": "string", "format": "datetime" } | ||
} | ||
} | ||
}, | ||
"mentionRule": { | ||
"type": "object", | ||
"description": "Allow replies from actors mentioned in your post." | ||
}, | ||
"followingRule": { | ||
"type": "object", | ||
"description": "Allow replies from actors you follow." | ||
}, | ||
"listRule": { | ||
"type": "object", | ||
"description": "Allow replies from actors on a list.", | ||
"required": ["list"], | ||
"properties": { | ||
"list": { "type": "string", "format": "at-uri" } | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't
object
types supposed to have 1 or moreproperties
? I maintain a lexicon codegen plugin and I noticed it's choking on these new typesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah looks like it was already reported: #1615