Fixes and updates to the preferences API #1575
Conversation
pfrazee
commented
Sep 11, 2023
pfrazee
commented
- Guards against duplicate entries in preferences and ensures consistent reads of the state when setting and getting
- Adds the "personal details" preference with the birth date that was recently added
|
Had to add a |
There was a problem hiding this comment.
all looks good 👍
one small thing: i'm not sure the order the preferences are returned is a part of the formal api contract - tho it is our our implementation does it (we explicitly order in the query)
that being said - this relieves the short term pain & fixing up the writes on the PDS should be the actual fix (and will work with either find or findLast)
Not a huge issue tbh. Duplicates are already an error case |
|
Published |
…Actor * origin: Get rate limit ip correctly (#1577) Remove temp.upgradeRepoVersion (#1588) Fix getRepo `since` (#1579) Prevent user pref races (#1576) Feature: block lists (#1531) Enable appview proxy in dev-env full network (#1580) Increase timeline threshold (#1573) @atproto/[email protected] Fixes and updates to the preferences API (#1575) Remove legacy repo sync impl (#1570) Move fuzzy matcher to appview (#1566) @atproto/[email protected] Add personal-details user preference with birth date (#1565) enable granular perms for publish action (#1563) maintain feed order (#1559)
* Fix to handle duplicate preference key entries * Add personal details preference API to sdk * Add Array.prototype.findLast() type declaration * Move interface declaration to ensure it's included in other package builds
* Fix to handle duplicate preference key entries * Add personal details preference API to sdk * Add Array.prototype.findLast() type declaration * Move interface declaration to ensure it's included in other package builds
