-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
identity: example of tsdoc rendered in to README #1598
base: main
Are you sure you want to change the base?
Conversation
Not terrible. If the type signatures just did full codeblocks with multiline indentation I think they'd be totally readable |
Wonder if we could patch the generator to use a triple-tick codeblock and then use prettier to clean it up. |
22dd8df
to
2d13d2f
Compare
Updated to render output to an Rendered (similar to previously): https://github.com/bluesky-social/atproto/blob/bnewbold/tsdoc-readme/packages/identity/API.md I can set up these API.md files for the most prominent packages, though i'm a bit ambivalent about the value. I would see them as a placeholder thing until we get a more full-fledged solution in place, like docusaurus or typedoc. The real work would be in the annotations/comments, which would transfer forward. Separately, I did a pass at trying to the full typedoc HTML generation system to run. It took a couple hours and didn't get it in a good place, I think i'm just not super familiar with TS/JS ecosystem. The workplace setup makes it sort of complex. |
Discussed with @pfrazee briefly earlier today, and will probably not merge this as-is, with the markdown file output. We'll just wait until we have a full/proper docs website. Will refactor this PR to keep the tsdoc additions specifically though. |
Rendered: https://github.com/bluesky-social/atproto/blob/22dd8df32aaf42e8bdba7e13bb04c10ef21fee73/packages/identity/README.md
Proof of concept of adding some tsdoc comments to this library, then using
tsdoc-markdown
to render it in to the README. I like the simplicity of the approach for these smaller packages, but a couple issues to consider: