-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passthrough proxying on xrpc-server #1730
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is beautiful 😍 🙇♂️
Closing this but keeping the branch around—will probably redo this in the future and hit all proxying services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements http passthroughs on xrpc-server and a proxy handler for forwarding the active request to another service. It's also now used on the relevant proxied app.bsky routes on the PDS to the appview. Some notes:
{ passthru: http.IncomingRequest }
from xrpc-server handlers, and the request will be faithfully passed through.xrpcServer.proxy()
which proxies the active request using a passthrough.defaultFetchHandler()
is no longer responsible for header normalization, and assumes the headers passed to it have already been normalized to lower-case.app.bsky
are now proxied usingxrpcServer.proxy()
. The exceptions are generally read-after-write endpoints.