Misc tests and fixes for entryway PDS #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
reviewed
Oct 13, 2023
packages/pds/src/config/secrets.ts
Outdated
| @@ -82,3 +91,8 @@ export type SigningKeyMemory = { | |||
| provider: 'memory' | |||
| privateKeyHex: string | |||
| } | |||
|
|
|||
| export type VerifyKeyMemory = { | |||
There was a problem hiding this comment.
i think the verify key can always be memory 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing some tests on auth flows around the entryway PDS. To make this work the test suite mocks now support multiple PDSes, and each PDS service can be marked as an entryway or not. If the PDS is not an entryway it will not provide certain proxying functionality. We also allow the PDS to be configured with a public key that can verify creds but not generate them itself.
PDS assignment has also gotten a bit more configurable, now supporting weighted assignment (which also allows us to enable/disable assignment to a given PDS).
Feature branch: #1722