Dont dump stacktrace in http logger middleware #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
approved these changes
Oct 19, 2023
devinivy
approved these changes
Oct 19, 2023
dholms
force-pushed
the
http-logger-stack-trace
branch
from
6aa9637 to
f60e2dc
Compare
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* dont dump stacktrace in http logger middleware * build branch * dont build * do in appview as well * build branch again * dont build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dumping stack trace for logs is expensive & we have tracing setup elsewhere. Instead we just log the error message & code.