Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues #1759

Closed
wants to merge 1 commit into from
Closed

Fix CI issues #1759

wants to merge 1 commit into from

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Oct 20, 2023

  • Upgrade express & ws (turned out not to be necessary)
  • Use axios instead of fetch for network mocks so we can mock the host header
  • Normalize output from docker for dev-infra

@dholms dholms changed the base branch from main to http-logger-stack-trace October 20, 2023 16:24
@dholms dholms changed the base branch from http-logger-stack-trace to main October 23, 2023 15:30
@dholms dholms changed the title Upgrade deps Fix CI issues Oct 23, 2023
@dholms dholms changed the base branch from main to http-logger-stack-trace October 23, 2023 16:11
@dholms dholms changed the base branch from http-logger-stack-trace to main October 23, 2023 18:28
@dholms
Copy link
Collaborator Author

dholms commented Oct 23, 2023

Closed in favor of #1763

@dholms dholms closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant