Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent clashing redis namespaces in tests #1764

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Oct 23, 2023

We got bday paradoxed 🙃

Turns out both appview_views_admin_get_moderation_reports & bsky_views_posts hash to 5312

I bumped this from 10k to 1m. Altho I'm curious if there's a reason that we require going to an int here instead of just using the string from dbPostgresSchema @devinivy?

Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If I recall correctly, the reason an integer is used here is mainly to avoid the redis commands getting very long. For example, when the indexers pull from multiple partitions, each partition will be listed in the command with its namespace. It also probably sidesteps issues with invalid key names since integers are always valid. But it's not a major deal either way.

@dholms dholms merged commit 4122109 into main Oct 24, 2023
10 checks passed
@dholms dholms deleted the bday-paradox-prevention branch October 24, 2023 14:46
mloar pushed a commit to mloar/atproto that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants