-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Manager #1769
Merged
Merged
Account Manager #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, real smooth!
devinivy
approved these changes
Oct 31, 2023
dholms
commented
Oct 31, 2023
]), | ||
) | ||
} catch (err) { | ||
if (err instanceof auth.ConcurrentRefreshError) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can see how i handle racing refreshes here
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the ServiceDB with an AccountManager abstraction
There are a few motivations involved in this:
The third point influenced the design of the AccountManager: database transactions are never exposed to routes, it is the AccountManager's prerogative to wrap transactional db queries within an abstraction. Routes should be able to call any function on the AccountManager without worrying about transactions locking.
I reworked many of the longer transactions (such as create account & refresh session) to do as much work ahead of time outside of the transaction, then do all of it's transactional writes quickly in "parallel".
I decided to take a slightly different approach with the code here. Instead of having services with a stateful db varaiable, I have files of "helper functions" that wrap a single postgres query. Then the AccountManager maintains a reference to the "AccountDB" and composes those helper functions into it's interface (sometimes just passing through directly to them)