Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entryway update handle flow, pds and agent caching #1785

Merged
merged 10 commits into from
Oct 31, 2023

Conversation

devinivy
Copy link
Collaborator

@devinivy devinivy commented Oct 30, 2023

A few misc fixes, improvements, and tweaks to the entryway setup:

  • Fix getAccountByEmail() which was giving a null for the user's did.
  • Cache getPds(did) results which is in the hot path of proxying.
  • Cache AtpAgents for the entryway's pdses.
  • Update entryway flow for updating account handles: should use pds's admin.updateAccountHandle endpoint to avoid entryway and pds identity.updateHandle routes depending on each other.
  • Only include didDoc alongside credentials when the pds endpoint is one of the entryway's pdses.

Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 💪

@devinivy devinivy merged commit f09a8d4 into multi-pds-auth Oct 31, 2023
10 checks passed
@devinivy devinivy deleted the multi-pds-auth-handle-updates branch October 31, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants