Delegate create account from entryway #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| const { did, handle, email, password, inviteCode, signingKey, plcOp } = | ||
| ctx.entrywayAgent | ||
| ? await validateInputsForEntrywayPds(ctx, input.body) | ||
| : await validateInputsForLocalPds(ctx, input.body) |
There was a problem hiding this comment.
This ternary is backwards! Or rather, it logically does the right thing, but the names of the two functions are backwards. Unless I'm mistaken, validateInputsForEntrywayPds contains the Local PDS validation logic, and vice versa. The functions should perhaps have their names swapped?
There was a problem hiding this comment.
You're right, it's confusing! Will take a look at fixing the names, adding better comments 👍 There are three different setups kicking around, and this package handles two of them:
- Being an entryway, e.g. bsky.social (not covered here)
- Being a pds behind an entryway, e.g. the mushroom servers (
validateInputsForEntrywayPds()) - Being a pds that doesn't use an entryway, e.g. a self-hoster (
validateInputsForLocalPds())
There was a problem hiding this comment.
Ahh that makes sense, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.