refactor(crypto): remove circular dependency #1942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
fix-crypto-circular-dep
branch
4 times, most recently
from
af69451 to
8967b76
Compare
matthieusieben
force-pushed
the
fix-crypto-circular-dep
branch
from
8967b76 to
64270cf
Compare
Merged
dholms
reviewed
Feb 19, 2024
| @@ -43,7 +42,7 @@ export class Secp256k1Keypair implements Keypair { | |||
| } | |||
|
|
|||
| publicKeyStr(encoding: SupportedEncodings = 'base64pad'): string { | |||
| return uint8arrays.toString(this.publicKey, encoding) | |||
| return toString(this.publicKey, encoding) | |||
There was a problem hiding this comment.
is there a reason to import this as just toString? if so I think it'd be nice to import it as something like ui8ToString or similar. otherwise toString is pretty generic & gotta check imports to see what it's coming from
dholms
approved these changes
Feb 19, 2024
|
Done. Also imported these changes in #2169. |
|
Merged through #2169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
crypto, there is a circular dependency betweendid.ts>plugins.ts>p256/plugin.ts>p256/operations.ts>did.ts. This PR fixes that by extracting common code into autils.tsfile, and uses that module instead ofdid.tsfrom plugin operations.