Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated app.bsky.unspecced.getPopular #1988

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

bnewbold
Copy link
Collaborator

We did dev comms on this back in Septmeber: #1648

A quick search of appview hits in prod turns up no hits to this endpoint in the past day.

Motivation is to just clear out unused code, reduce confusion, and one less thing to deal with for appview v2.

@bnewbold bnewbold requested review from devinivy and dholms December 25, 2023 16:53
Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍

Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff 👍

@bnewbold bnewbold merged commit 51fcba7 into main Jan 9, 2024
10 checks passed
@bnewbold bnewbold deleted the bnewbold/remove-get-popular branch January 9, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants