-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lexicons for 3rd-party labelers #2016
Conversation
In the preferences, I have the user setting visibility for label groups. In the labeler declaration, however, I have the labeler declaring the supported label values. My thinking is that our label definitions will be updated to include the label <=> label-group mapping, and that we'll assemble the label groups from the list of declared labels. |
Unsure if we want to support |
I would advocate yes |
Not quite sure I follow here... By "label definitions" do you mean the signed label objects that get passed around? Or do you mean the definitions that live over here? |
Just bear in mind, it's not configurable. Essentially this would give any labeler you add the power to quietly |
Yeah the latter, the label value definitions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍
Lexicons for: