Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexicons for 3rd-party labelers #2016

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Lexicons for 3rd-party labelers #2016

merged 7 commits into from
Jan 9, 2024

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Jan 4, 2024

Lexicons for:

  • labeler records
  • labeler views
  • xrpc methods for fetching labelers

@pfrazee
Copy link
Collaborator Author

pfrazee commented Jan 4, 2024

In the preferences, I have the user setting visibility for label groups. In the labeler declaration, however, I have the labeler declaring the supported label values. My thinking is that our label definitions will be updated to include the label <=> label-group mapping, and that we'll assemble the label groups from the list of declared labels.

@pfrazee
Copy link
Collaborator Author

pfrazee commented Jan 4, 2024

Unsure if we want to support ! imperative labels from 3P labelers

@dholms
Copy link
Collaborator

dholms commented Jan 4, 2024

Unsure if we want to support ! imperative labels from 3P labelers

I would advocate yes

@dholms
Copy link
Collaborator

dholms commented Jan 4, 2024

My thinking is that our label definitions will be updated to include the label <=> label-group mapping, and that we'll assemble the label groups from the list of declared labels.

Not quite sure I follow here... By "label definitions" do you mean the signed label objects that get passed around? Or do you mean the definitions that live over here?

@pfrazee
Copy link
Collaborator Author

pfrazee commented Jan 4, 2024

Unsure if we want to support ! imperative labels from 3P labelers

I would advocate yes

Just bear in mind, it's not configurable. Essentially this would give any labeler you add the power to quietly !filter, for instance

@pfrazee
Copy link
Collaborator Author

pfrazee commented Jan 4, 2024

My thinking is that our label definitions will be updated to include the label <=> label-group mapping, and that we'll assemble the label groups from the list of declared labels.

Not quite sure I follow here... By "label definitions" do you mean the signed label objects that get passed around? Or do you mean the definitions that live over here?

Yeah the latter, the label value definitions

Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@dholms dholms marked this pull request as ready for review January 8, 2024 23:41
@dholms dholms changed the base branch from main to 3p-labelers January 9, 2024 21:34
@dholms dholms merged commit 169c359 into 3p-labelers Jan 9, 2024
10 checks passed
@dholms dholms deleted the 3p-labeler-schemas branch January 9, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants