-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - 3rd party labelers #2032
Merged
Merged
Changes from 170 commits
Commits
Show all changes
305 commits
Select commit
Hold shift + click to select a range
d828187
adding some basic views
dholms a5c227a
feed hydration, add blocks to post hydration
devinivy bdd2fb8
pass over notification hydration
devinivy 8d669bf
tidy
devinivy fc70842
merge
dholms 4fb3d24
implement getProfile
dholms 6d162a0
hydrate post aggregation and viewer state
devinivy 95bad68
fix
devinivy b1dfbde
fix codegen
dholms 2298406
get some tests passing!
dholms 4ab0bbb
add takedowns & some like bugfixing
dholms 9fd84ea
all profile tests passing!
dholms 39aa7b4
likes test
dholms 5cd6fc7
follow endpoints using data plane
devinivy eedc2ea
reorg follow block rules
devinivy 9d64919
reposts
dholms 7fb5ea9
post views!
dholms 7395f8d
implement getList w/ dataplane caveat
devinivy 571f9f6
adjust dataplane getListMembers to return listitem uris
devinivy 640b792
implement getListMutes and -Blocks w/ dataplane
devinivy c342d38
suggestions
dholms 0126f08
timeline
dholms a9e7148
misc view fixes
devinivy 49d79ee
view fixes for mutes, self-mute/block
devinivy bb3d377
author feed
dholms 396e210
feed gen routes
dholms 1ad4b84
tidy
dholms bee9c6d
misc block/mute fixes
devinivy 19f2f47
list feed & actor likes
dholms 97fcb3c
implement getLists, fix some empty cursors
devinivy cd4b277
implement getMutes, empty profile description fix
devinivy 265a2e3
implement getBlocks, block application fix
devinivy 12e8edb
implement getSuggestedFollowsByActor, needs some fixes
devinivy 0db39b6
feed generation
dholms b6fb606
search routes
dholms e358500
threads
dholms defb28c
tidy
dholms 4266b3a
fix some snaps
dholms d7fdc08
fix getSuggestedFollowsByActor
devinivy 10a10b8
implement listNotifications
devinivy 17bdb01
implement getUnreadCount w/ dataplane
devinivy 3707a75
implement notifications.updateSeen w/ dataplane
devinivy 1f78afa
3rd party blocking tests
dholms 7d249bd
blocked profile viewer
dholms 9f92374
add search mocks
dholms 69d8a2b
refactor getFeed
dholms c13fca9
createPipeline -> createPipelineNew
dholms a4dc101
basic replygating functionality on dataplane w/o filtering violating …
devinivy 764e0da
hack threadgates into dataplane, apply gates
devinivy cecc669
deterministic thread orders in dataplane
devinivy f089eb5
misc cleanup around dataplane
devinivy f6de678
upgrade typescript to v5.3
devinivy 549b464
update typescript linter deps
devinivy 70cf5c2
sync bsky proto, codegen
devinivy 9574a86
update dataplane, sync with bsky proto updates
devinivy d8aa699
remove indexer, ingester, daemon, moderation services from appview
devinivy 61a0389
convert more bsky internals to dataplane, remove custom feedgens, imp…
devinivy 96f3828
remove bsky services. db and indexing logic into mock dataplane.
devinivy c3fb682
remove tests not needed by appview v2, misc reorg
devinivy 975ba4d
add basic in-mem repo subscription to dataplane mock
devinivy a48903d
fix dev-env, bsky tests, bsky build
devinivy 8371879
cull bsky service entrypoint
devinivy 012c754
add bsky service readme
devinivy f2edcfd
build
devinivy a93ae30
tidy
devinivy 9229cc2
tidy, fix pds proxy tests
devinivy 22b3c2f
Merge pull request #1939 from bluesky-social/bav-v2-hydration
devinivy 3b85cbf
fix
devinivy 3b9a5cb
fix bsky entrypoint deps
devinivy e8258eb
support http2 grpc client
devinivy 438025e
build
devinivy f431958
fix dataplane bad tls config/default
devinivy 1dab449
support multiple dataplane urls, retry when unavailable
devinivy 065149a
build
devinivy 6f05b42
tidy/fix
devinivy 1da49cc
move dataplane mock tests into their own dir
devinivy 62603e0
cover label hydration through timeline test
devinivy b40e8c6
bring back labels in appview tests
devinivy 9b2153f
remove unused db primary/replica/coordinator from bsky dataplane
devinivy 1d8a4f1
Merge pull request #1982 from bluesky-social/bav-v2-drop-pg
devinivy 3feee71
Merge pull request #1992 from bluesky-social/bav-v2-config-pass1
devinivy c67e1f1
Merge pull request #1993 from bluesky-social/bav-v2-dataplane-clients
devinivy 8668a2f
bsky proto add cids to contracts, buf codegen
devinivy 246fb09
sync-up bsky data-plane w/ codegen updates
devinivy 1ca11d2
start using dataplane interaction endpoints
devinivy 36b72bf
add file
devinivy dd6fe98
Merge pull request #2008 from bluesky-social/appview-v2-proto-cids
devinivy 5e829ff
avoid overfetching from dataplane, plumb feed items and cids
devinivy 0b6752a
pass refs through for post viewer state
devinivy bebb77b
Lexicons: Add labeler prefs, labeler declaration, and get labeler routes
pfrazee 59d6cf7
Add labelerViewBasic and update embed views
pfrazee 9b944f8
Fix typo
pfrazee 53c33f2
switch list feeds to use feed item in dataplane
devinivy fabb122
handle not found err on get-thread dataplane call
devinivy 34d3a7c
support use of search service rather than dataplane methods
devinivy deb8c4d
mark some appview v2 todos
devinivy 3d71d89
tidy
devinivy 45c6237
still use dataplane on search endpoints when search service is not co…
devinivy f006a08
fix pds test
devinivy 03b6ef6
Switch to labelerViewDetailed
pfrazee 354d63c
Move label and report values to refs
pfrazee d513e5d
Add getActorLabelers
pfrazee 4463443
lint
dholms 88f2f21
merge main
dholms 98613e9
fix up bsky tests & snaps
dholms f937800
small diff to open pr
dholms 2362de4
rm new line
dholms 169c359
Merge pull request #2016 from bluesky-social/3p-labeler-schemas
dholms 418d700
codegen schemas
dholms 14d8773
tidy migrations
dholms ce9dc75
Merge branch 'appview-v2' into 3p-labelers
dholms 1880a21
Merge branch '3p-labelers' into 3p-labeler-record-handling
dholms da9f699
table + indexing
dholms 2363c0a
protos
dholms 1b7ee9f
rename lexicons
dholms 15268b5
views, hydration + rename lexicons
dholms d27af5d
rest of routes
dholms 83dbced
data plane routes
dholms 7edc5cc
parse labelers from req
dholms 807b38a
fix appview-v2 docker build
devinivy 0a45fea
Support label issuer tied to appview v2 (#2033)
devinivy 9cbf2bf
hydrate context
dholms 90e45e6
tidy header logic
dholms 5c92f03
integrating into more routes
dholms 73cf9cd
more routes
dholms d6ab359
wrap up rest
dholms bc6b0d8
add mock labeler
dholms 3852574
rework labelerlexicons
dholms 016c4a8
merge lex rework
dholms 2686f3d
tidy lexs
dholms 75a4a77
Merge branch '3p-labeler-lex-rework' into 3p-labeler-record-handling
dholms 08fdcba
codegen new lexicons
dholms 788d4fc
integrate lexicon rework
dholms 571e144
merge
dholms fc99baf
add proxy logic
dholms d63ef89
Merge branch '3p-labeler-record-handling' into 3p-labeler-hydration
dholms 3c9ebbe
forward labeler headers through pds
dholms 78866a6
tweak label header parsing
dholms 0cf9b8b
remove did from scheams
dholms a4eff3e
Merge branch '3p-labeler-lex-rework' into 3p-labeler-record-handling
dholms 2d7267b
update indexing for lexs
dholms cd68c4e
tests for mod service views
dholms ad37bb3
Merge branch '3p-labeler-record-handling' into 3p-labeler-hydration
dholms e8d97f4
label hydration test
dholms c2d0cd7
Add 'associated' to profileViewDetailed
pfrazee ececc93
Rename labelers to mods in preferences
pfrazee 0a7b8a8
Change uri to did in mod preferences
pfrazee 5ba01bd
couple more
dholms 027ebfc
merge
dholms 9de677b
syntax tweaks
dholms 32624d4
Merge branch '3p-labeler-lex-rework' into 3p-labeler-record-handling
dholms 4e99c06
integrate updated lexicons
dholms 8d90f05
update view snap
dholms 2007a24
Merge branch '3p-labeler-record-handling' into 3p-labeler-hydration
dholms 104f971
handle mod service embeds
dholms 57ab568
merge
dholms c515712
tidy
dholms 45dfdff
fix mock
dholms 5a6915f
Merge branch 'appview-v2' into 3p-labelers
dholms d28a069
Merge branch '3p-labelers' into 3p-labeler-lex-rework
dholms d7efab1
lint
dholms c52332f
Merge branch '3p-labeler-lex-rework' into 3p-labeler-record-handling
dholms 1718b63
Merge branch '3p-labeler-record-handling' into 3p-labeler-hydration
dholms 1583176
Merge pull request #2040 from bluesky-social/3p-labeler-lex-rework
dholms 7bab77e
base default labels of config var
dholms 9465429
fix label hydration
dholms cbfe0b9
Merge remote-tracking branch 'origin/appview-v2-fix-overfetching1' in…
devinivy 1c14449
Merge remote-tracking branch 'origin/appview-v2-not-found-search' int…
devinivy f2cfd45
Appview v2: handle empty cursor on list notifications (#2017)
devinivy c592ae8
Update appview v2 to use author feed enum (#2047)
devinivy 59704b3
Appview v2: utilize sorted-at field in bsky protos (#2050)
devinivy 75d3079
remove all dataplane usage of GetLikeCounts, switch to GetInteraction…
devinivy 3c6287a
Appview v2, sync w/ changes to protos (#2071)
devinivy 2178b15
Appview v2 initial implementation for getPopularFeedGenerators (#2072)
devinivy c8129d5
merge
dholms 9935a76
fixes
dholms 3e8431e
fix feed tests
dholms 37ac9b4
fix bsync mock
dholms 714b117
format
dholms 8194bc1
remove unused config
devinivy 96a5a9b
final merge
dholms 827f9e7
fix lockfile
dholms 8f5306f
another lockfile fix
dholms 0fb4e5b
fix duplicate type
dholms 82c0855
fix dupplicate test
dholms 6a664ed
Appview v2 handling clearly bad cursors (#2092)
devinivy ad72ef7
Appview v2 no notifs seen behavior (#2096)
devinivy 29230db
Appview v2 dataplane retries based on client host (#2098)
devinivy ed9e234
don't apply negated labels
devinivy 6dd9331
display suspensions on actor profile in appview v2
devinivy b47e28d
Appview v2 use dataplane for identity lookups (#2095)
devinivy 8e59aad
Appview v2: apply safe takedown refs to records, actors (#2107)
devinivy abf4d44
Fix timing on appview v2 repo rev header (#2113)
dholms a2b51fb
fix post thread responses
devinivy 464faba
Appview v2 don't apply 3p self blocks (#2112)
devinivy 1970529
Appview v2 search for feed generators (#2118)
devinivy be4dc5a
Appview v2 config tidy (#2117)
devinivy b292023
Appview v2: don't apply missing modlists (#2122)
dholms 374d2b8
Appview v2 enforce post thread root boundary (#2120)
devinivy 5cd08e4
Appview v2 fix admin environment variable (#2137)
devinivy e610da9
Remove re-pagination from getSuggestions (#2145)
devinivy 94a59e5
Adjust wording for account suspension (#2153)
dholms 593ee1e
Merge pull request #2034 from bluesky-social/3p-labeler-record-handling
dholms 901acb9
Merge pull request #2035 from bluesky-social/3p-labeler-hydration
dholms 8497d18
Appview v2: fix not-found and blocked uris in threads (#2201)
devinivy c2a6577
:sparkles: Show author feed of takendown author to admins only (#2197)
foysalit ae0180a
fold in cid, auth, tracing, node version changes
devinivy d65d814
Merge remote-tracking branch 'origin/main' into appview-v2-merge
devinivy ed97d0a
remove dead config from bsky service entrypoint
devinivy bba2eb4
build
devinivy f855938
remove ozone test codepaths for appview v2
devinivy 5a60f5d
tidy, docs fix
devinivy 142cdb8
merge appview-v2
dholms a65beef
fix test
dholms 87a87d6
add additional user counts
dholms 4253c62
add associated data to profiles
dholms 543df85
update snaps
dholms 5d860cf
update to is_mod_service
dholms 4608ad2
Merge pull request #2231 from bluesky-social/appview-v2-merge
devinivy 5b39f7c
format
devinivy c636761
Merge remote-tracking branch 'origin/appview-v2' into 3p-labelers
devinivy fb70b3b
tidy
devinivy b1f3f94
merge main
dholms 1f93719
merge
dholms 4ba6266
3p labeler sdk updates (#2176)
pfrazee 4f42f34
Lexicon: Add custom label definitions and remove modservice descriptions
pfrazee 4f7ca51
Lexicon: Update moderation prefs
pfrazee 6b53142
SDK updates: remove label groups, reduce builtin labels, update mod-p…
pfrazee 8097adf
Lexicon: Update global labels with new reduced set
pfrazee 6334f33
Lexicon: Remove moderation.getService and add detailed option to getS…
pfrazee be81d51
Lexicons: add severity=none to custom label value defs
pfrazee ce9ffd4
Implement custom label-value definition tooling
pfrazee 36fb2bf
All custom labels are no-self
pfrazee a03632f
Backend impl for labeler lexicon updates (#2258)
dholms 343927e
Lexicon: modservice -> labeler
pfrazee 0f615b5
Remove x- prefix behavior; add label value syntax rules; add custom l…
pfrazee 94d8eb5
Lexicon: Remove the ability to choose a defaultSetting from custom la…
pfrazee e3b33a5
Rework test suites
pfrazee 05331d1
Give behaviors to all labels regardless of target
pfrazee bfd942d
sync up backend with lex changes
dholms 375a4ca
fix labelers in dev-env agent
dholms a34dae9
lint protos
dholms 8f48d4d
Merge pull request #2237 from bluesky-social/3p-labelers-lexicon-updates
dholms ef31c71
Merge branch '3p-labelers' into profile-associated
dholms 31b19dd
update protos & views
dholms e8a53f2
small bugfix & update tests
dholms e4554a5
Merge pull request #2232 from bluesky-social/profile-associated
dholms 4acf5fc
tweak protos
dholms c0e0006
merge main
dholms cc40e86
fix build issue from merge
dholms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,4 @@ pnpm-lock.yaml | |
.pnpm* | ||
.changeset | ||
*.d.ts | ||
packages/bsky/src/data-plane/gen |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
{ | ||
"lexicon": 1, | ||
"id": "app.bsky.moderation.defs", | ||
"defs": { | ||
"modServiceView": { | ||
"type": "object", | ||
"required": ["uri", "cid", "creator", "indexedAt"], | ||
"properties": { | ||
"uri": { "type": "string", "format": "at-uri" }, | ||
"cid": { "type": "string", "format": "cid" }, | ||
"creator": { "type": "ref", "ref": "app.bsky.actor.defs#profileView" }, | ||
"description": { | ||
"type": "string", | ||
"maxGraphemes": 300, | ||
"maxLength": 3000 | ||
}, | ||
"descriptionFacets": { | ||
"type": "array", | ||
"items": { "type": "ref", "ref": "app.bsky.richtext.facet" } | ||
}, | ||
"likeCount": { "type": "integer", "minimum": 0 }, | ||
"viewer": { "type": "ref", "ref": "#modServiceViewerState" }, | ||
"indexedAt": { "type": "string", "format": "datetime" }, | ||
"labels": { | ||
"type": "array", | ||
"items": { "type": "ref", "ref": "com.atproto.label.defs#label" } | ||
} | ||
} | ||
}, | ||
"modServiceViewDetailed": { | ||
"type": "object", | ||
"required": ["uri", "cid", "creator", "policies", "indexedAt"], | ||
"properties": { | ||
"uri": { "type": "string", "format": "at-uri" }, | ||
"cid": { "type": "string", "format": "cid" }, | ||
"creator": { "type": "ref", "ref": "app.bsky.actor.defs#profileView" }, | ||
"description": { | ||
"type": "string", | ||
"maxGraphemes": 300, | ||
"maxLength": 3000 | ||
}, | ||
"descriptionFacets": { | ||
"type": "array", | ||
"items": { "type": "ref", "ref": "app.bsky.richtext.facet" } | ||
}, | ||
"policies": { | ||
"type": "ref", | ||
"ref": "app.bsky.moderation.defs#modServicePolicies" | ||
}, | ||
"likeCount": { "type": "integer", "minimum": 0 }, | ||
"viewer": { "type": "ref", "ref": "#modServiceViewerState" }, | ||
"indexedAt": { "type": "string", "format": "datetime" }, | ||
"labels": { | ||
"type": "array", | ||
"items": { "type": "ref", "ref": "com.atproto.label.defs#label" } | ||
} | ||
} | ||
}, | ||
"modServiceViewerState": { | ||
"type": "object", | ||
"properties": { | ||
"like": { "type": "string", "format": "at-uri" } | ||
} | ||
}, | ||
"modServicePolicies": { | ||
"type": "object", | ||
"required": ["reportReasons", "labelValues"], | ||
"properties": { | ||
"description": { | ||
"type": "string", | ||
"maxGraphemes": 10000, | ||
"maxLength": 100000 | ||
}, | ||
"descriptionFacets": { | ||
"type": "array", | ||
"items": { "type": "ref", "ref": "app.bsky.richtext.facet" } | ||
}, | ||
"reportReasons": { | ||
"type": "array", | ||
"items": { | ||
"type": "ref", | ||
"ref": "com.atproto.moderation.defs#reasonType" | ||
} | ||
}, | ||
"labelValues": { | ||
"type": "array", | ||
"items": { | ||
"type": "ref", | ||
"ref": "com.atproto.label.defs#labelValue" | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"lexicon": 1, | ||
"id": "app.bsky.moderation.getService", | ||
"defs": { | ||
"main": { | ||
"type": "query", | ||
"description": "Get information about a moderation service.", | ||
"parameters": { | ||
"type": "params", | ||
"required": ["did"], | ||
"properties": { | ||
"did": { "type": "string", "format": "did" } | ||
} | ||
}, | ||
"output": { | ||
"encoding": "application/json", | ||
"schema": { | ||
"type": "ref", | ||
"ref": "app.bsky.moderation.defs#modServiceViewDetailed" | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
{ | ||
"lexicon": 1, | ||
"id": "app.bsky.moderation.getServices", | ||
"defs": { | ||
"main": { | ||
"type": "query", | ||
"description": "Get information about a list of moderation services.", | ||
"parameters": { | ||
"type": "params", | ||
"required": ["dids"], | ||
"properties": { | ||
"dids": { | ||
"type": "array", | ||
"items": { "type": "string", "format": "did" } | ||
} | ||
} | ||
}, | ||
"output": { | ||
"encoding": "application/json", | ||
"schema": { | ||
"type": "object", | ||
"required": ["views"], | ||
"properties": { | ||
"views": { | ||
"type": "array", | ||
"items": { | ||
"type": "ref", | ||
"ref": "app.bsky.moderation.defs#modServiceView" | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ | ||
"lexicon": 1, | ||
"id": "app.bsky.moderation.service", | ||
"defs": { | ||
"main": { | ||
"type": "record", | ||
"description": "A declaration of the existence of moderation service.", | ||
"key": "literal:self", | ||
"record": { | ||
"type": "object", | ||
"required": ["policies", "createdAt"], | ||
"properties": { | ||
"description": { | ||
"type": "string", | ||
"maxGraphemes": 300, | ||
"maxLength": 3000 | ||
}, | ||
"descriptionFacets": { | ||
"type": "array", | ||
"items": { "type": "ref", "ref": "app.bsky.richtext.facet" } | ||
}, | ||
"policies": { | ||
"type": "ref", | ||
"ref": "app.bsky.moderation.defs#modServicePolicies" | ||
}, | ||
"labels": { | ||
"type": "union", | ||
"refs": ["com.atproto.label.defs#selfLabels"] | ||
}, | ||
"createdAt": { "type": "string", "format": "datetime" } | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
version: v1 | ||
plugins: | ||
- plugin: es | ||
opt: | ||
- target=ts | ||
- import_extension=.ts | ||
|
||
out: src/data-plane/gen | ||
- plugin: connect-es | ||
opt: | ||
- target=ts | ||
- import_extension=.ts | ||
out: src/data-plane/gen |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna suggest we drop the
policies.description
here until we feel more confident about how we're representing documents