Add from:me search syntax #2044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-ext
force-pushed
the
feat/search-from-me
branch
from
49cd6ec to
54e65ac
Compare
|
closing this in favor of adding a param to searchPostsSkeleton, I believe that'd be the better choice as Palomar gets to handle it |
|
@mary-ext I think the AppView might actually be the best place to do this near-term? Not sure we want to pass DID on to palomar if we don't need to (TBD). Putting it in the appview allows mixing in account context, while not having things be client-specific. |
|
Ah yeah, I'll keep this open then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to bluesky-social/social-app#2504 which does it in the client itself
Adds
from:meconvenient search syntax to search your own posts, done by replacing instances offrom:mewith the account's DID, with special care taken to avoid string replacements inside quotes as they are exact string matches.I thought of adding it to Palomar directly, but since Palomar is unauthenticated I decided it'd be wise to implement it in the AppView layer instead.