Appview v1 generating and ingesting mute ops w/ bsync #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
reviewed
Jan 22, 2024
| subject: subjectDid, | ||
| }) | ||
| } catch (err) { | ||
| req.log.warn(err, 'failed to sync mute op to bsync') |
There was a problem hiding this comment.
i think we wanna throw here if bsyncOnlyMutes is true because then the operation failed
if it's false then it was partially applied but presumably the local db is considered the canonical state?
There was a problem hiding this comment.
Yep 💯 thanks for nabbing that.
dholms
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes here:
Along the way I got bsync setup in the dev-env package, and made a small change to the convention for where built protos are written (now built into the package's
src/protos/rather than the more ambiguoussrc/gen/).