Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appview v1 maintaining device tokens and pushing notifications w/ courier #2073

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Appview v1 maintaining device tokens and pushing notifications w/ courier #2073

merged 6 commits into from
Jan 24, 2024

Conversation

devinivy
Copy link
Collaborator

Two main changes here:

  • allow appview frontends to maintain device tokens with courier. Depending on the configuration, the appview frontends might write only to the db locally, only to courier, or both.
  • allow appview indexer to push notifications using courier.

Did a mini cleanup pass on the NotificationServer along the way.

dholms
dholms approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🙌

@devinivy devinivy merged commit 6a318b9 into main Jan 24, 2024
11 checks passed
@devinivy devinivy deleted the appview-v1-courier branch January 24, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholms dholms dholms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinivy @dholms