Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove appview feedgen #2106

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Remove appview feedgen #2106

merged 4 commits into from
Jan 30, 2024

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Jan 29, 2024 •
edited
Loading

This removes the in-appview feed generator.

All of our feeds are now moved over to a proper feed generator and this simplifies the logic for getFeed.

Also took the oppurtunity to deprecate the unspecced getTimelineSkeleton rout (verified that it has not been used at all in the last week).

devinivy
devinivy approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤤 so nice to see this tidied up.

@dholms dholms merged commit f023494 into main Jan 30, 2024
10 checks passed
@dholms dholms deleted the remove-appview-feed-gen branch January 30, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinivy devinivy devinivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dholms @devinivy