Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify appview automod #2108

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Simplify appview automod #2108

merged 2 commits into from
Jan 30, 2024

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Jan 29, 2024

Since we're running a dedicated auto-mod service, we can pull the abyss & fuzzy matcher tests out of the in-appview automod.

Once we verify that img labeling is working correctly in the new auto-mod, we can fully deprecate the indexer automod

@bnewbold
Copy link
Collaborator

This looks directionally correct to me:

  • only in AppView, PDS still does some keyword stuff (eg, when creating account, changing handle, and some record updates like display name)
  • removing abyss from appview indexing: check, automod is doing this in prod
  • removing appview-side keyword checks resulting in mod reports: check, automod is doing this in prod

@dholms dholms merged commit cdb89c3 into main Jan 30, 2024
10 checks passed
@dholms dholms deleted the simplify-automod branch January 30, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants