update descriptions in Lexicons #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
emilyliu7321
approved these changes
Feb 2, 2024
dholms
approved these changes
Feb 2, 2024
|
@dholms when I went to rebase, codegen, and merge this, I got some scary diffs like: @@ -167,39 +167,39 @@ export class Server {
export class ComNS {
_server: Server
- atproto: ComAtprotoNS
+ atproto: AtprotoNSis there some refactor in-flight? This PR is docs-only, so i'm open to merging as-is; or if somebody else knows how to wrangle the codegen. It would be great to get this in by early next week, but also not a huge deal. |
|
See also: #1713 |
bnewbold
force-pushed
the
bnewbold/lex-desc
branch
from
b3e9989 to
e4f33df
Compare
|
Ooookey doke, figure out I was just missing Also did a rebase before codegen. closes: #1713 |
|
Ah yup sorry! We updated the lexgen cli & you probably out an out of date build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably need to do a codegen to update comments etc, but i'm not sure if that might cause merge conflicts with large feature branches.
Annotated many ambiguous endpoints as requiring auth (or not), but did not annotate all. Likewise annotated some as being implemented by specific network services, but didn't do this for every endpoint. This was taking a long time so I mostly just included stuff I was confident about, but might be ambiguous or confusing to devs.
Motivation here is to improve auto-generated docs.
Emily tagged for copy-editing and style, Devin for factual correctness.