-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable creation of unknown record types #2171
Conversation
packages/pds/src/repo/prepare.ts
Outdated
path: string[] = [], | ||
layer = 0, | ||
): FoundBlobRef[] => { | ||
if (layer > 10) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a gut check that 10 layers is enough for e.g. the images within a record-with-media (counting in my head I suppose it's probably fine, close to 5?). It just feels a little conservative, I'd be down to increase this a bit either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup fair point, I can bump it up 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💎
FYI, I have this parallel PR with some additional data check test cases: It checks for things like Should we consider preventing updates to |
Enables the creation/update of records of unknown lexicon.
By default, a write is still "validated" which requires the existence of the lexicon. However, if the request to the pds is set to
validated: false
, then the write will be let through. This is higher friction than we want it to be long term, however we don't have any form of dynamic schema resolution yet and I think the extra bit of friction is worth it such that the lack of guardrails is better surfaced to developers.We generically walk the record to find and associate any blobrefs, even for records that we do not know the schema for.
Some other generic behavior is enforced as well:
$type
matching collection namecreatedAt
adheres to the proper date format