Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entryway account migration #2185

Merged
merged 10 commits into from
Feb 21, 2024
Merged

Entryway account migration #2185

merged 10 commits into from
Feb 21, 2024

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Feb 15, 2024 •
edited
Loading

Partial Entryway impl for account migration
Sister PR to #2179

This implements outgoing account migration from an entryway, but does not yet support incoming.
Specifically, it:

  • proxies relevant routes to the user's pds
    • getServiceAuth
    • activateAccount
    • deactivateAccount
  • adds logic for requestPlcOperationSignature and signPlcOperation

@dholms dholms mentioned this pull request Feb 15, 2024
Merged
@dholms dholms marked this pull request as ready for review February 15, 2024 23:15
devinivy
devinivy approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@dholms dholms merged commit 40397e5 into multi-pds-auth Feb 21, 2024
10 checks passed
@dholms dholms deleted the entryway-account-migration branch February 21, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinivy devinivy devinivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dholms @devinivy