-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce #reviewOptional as reviewState for non-impactful events on a subject #2235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the name #reviewOptional
. Maybe #reviewNone
or "empty" or something like that?
Automod already does label + create review in cases where that is needed or appropriate; it will also be good to be able to apply labels without requiring review. This is basically just parity with how image auto-labeling works (IIRC).
I don't have strong opinion on the naming so happy to rename to |
"reviewState": "com.atproto.admin.defs#reviewEscalated", | ||
"reviewState": "com.atproto.admin.defs#reviewOpen", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change stood out to me a little—just making sure we can account for the change in behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch! as discussed in slack, this was caused by a race condition and I missed the update in snapshot.
pushed a fix by adding forUpdate()
to the current status selector query which should be safe since we shouldn't have that many concurrent events on the same subject.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one question, but looks good!
Up until now, emitting events like
modEventComment
ormodEventTag
would set thereviewState
of the subject toreviewOpen
which is a bit disruptive to the moderation queue since these events are meant for setting optional metadata on the subject and should not require a moderator's review. This PR introduces a newreviewOptional
state which will be set when such events are emitted on a subject with no prior (impactful) events.TODO:
This means for events with type
modEventLabel
, we will no longer set the subject's status toreviewOpen
so if tools like automod wants a labeled subject to be reviewd by a moderator, it will have to emit a separatemodEventReport
event.