❇️ Custom namespace for ozone related lexicons #2253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foysalit
commented
Mar 11, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "lexicon": 1, | |||
| "id": "com.atproto.admin.emitModerationEvent", | |||
| "id": "tools.ozone.emitModerationEvent", | |||
There was a problem hiding this comment.
I know this introduces more work but just FYI, @bnewbold had a comment somewhere in slack recommending that we should probably follow the pattern we already have elsewhere and sub-namespace these to tools.ozone.event and tools.ozone.communication, so on and so forth. I kinda liked that idea and got it almost working here https://github.com/bluesky-social/atproto/pull/2253/files#diff-37557b8ffd69b330154d455aee69b2fb093af41bf938cdc16300dfcf93c7a8af
|
I think the primary branch for this work is: #2288 |
|
Inspiration for & superseded by #2288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves ozone specific lexicons to a new namespace
tools.ozone.