Action !takedown labels in hydrator #2270
Conversation
dholms
changed the title
| const includesTakedownLabel = (labels: Label[]) => { | ||
| return labels.some((l) => l.val === TAKEDOWN_LABEL) | ||
| } |
There was a problem hiding this comment.
So many labels pass through here and the hit rate on takedowns is so low that I wouldn't shy away from a little optimization... if it's straightforward. Maybe it would be easy to make the label hydration state a little richer to track which lists have a takedown? If it's not straightforward then I'm sure it's fine for the time being as-is.
There was a problem hiding this comment.
yeah I like it - I added a materialized isTakendown flag to the label hydration map
Also makes it easier to extend the functionality with either more labels that toggle the flag or other types of flags 👍
| } | ||
|
|
||
| const includesTakedownLabel = (labels: Label[]) => { | ||
| return labels.some((l) => l.val === TAKEDOWN_LABEL) |
There was a problem hiding this comment.
Is it guaranteed that none of the labels here have a neg: true?
There was a problem hiding this comment.
Should be, but I'll add a check just in case 👍
|
are we going to do the |
| @@ -61,7 +61,9 @@ export class Views { | |||
| // ------------ | |||
|
|
|||
| actorIsTakendown(did: string, state: HydrationState): boolean { | |||
| return !!state.actors?.get(did)?.takedownRef | |||
| if (state.actors?.get(did)?.takedownRef) return true | |||
| if (state.labels?.get(did)?.isTakendown) return true | |||
There was a problem hiding this comment.
Something we can punt for now—but if you are taken down via a label, perhaps you should receive the label rather than have it apply on the server side.
There was a problem hiding this comment.
I think we can punt for now as we're still pairing those with pds takedowns
There was a problem hiding this comment.
But agreed, needs to be addressed soon 👍
Apply takedowns to server responses based on if some content has a
!takedownor!suspendlabel from a configured labeler