lexicon nits: use string format uri in more places
#2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in #2111
This is technically a Lexicon evolution rules-breaking change, because it is adding a non-optional restriction on an existing field. This is part of final cleanup of existing Lexicons trying to hit all such final "breaking" changes.
In practice, I think this is basically a no-op as we aren't validating
urifields against any format or regex in the typescript implementation (I probably will require them to be URIs of some sort in the golang Lexicon validator).Some of these changes appeared earlier in #1994, which was mostly about string length limits, and we needed to revert. I'm trying to both be more complete here, and to break up these changes in to more focused chunks.