Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tear down docker when tests fail #2489

Merged
merged 3 commits into from
May 14, 2024
Merged

Tear down docker when tests fail #2489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9504e5
add set +e before docker cmd
dholms May 14, 2024
1427753
add comment
dholms May 14, 2024
299b258
tidy
dholms May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/dev-infra/_common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ main_docker() {
echo "all services ${services} are already running"
fi

# do not exit when following commands fail, so we can intercept exit code & tear down docker
set +e

# setup environment variables and run args
export_env
"$@"
Expand Down
Loading