Add subscription routes #3156
Closed
Add subscription routes #3156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelbsky
force-pushed
the
bsky-subscription-routes
branch
from
a2b02ef to
c3f04dc
Compare
rafaelbsky
force-pushed
the
bsky-subscription-dataplane
branch
from
a769904 to
95e5411
Compare
rafaelbsky
force-pushed
the
bsky-subscription-routes
branch
from
c3f04dc to
010ed82
Compare
rafaelbsky
force-pushed
the
bsky-subscription-dataplane
branch
from
95e5411 to
9e11d24
Compare
rafaelbsky
force-pushed
the
bsky-subscription-routes
branch
6 times, most recently
from
04d4712 to
345cca1
Compare
rafaelbsky
force-pushed
the
bsky-subscription-dataplane
branch
from
9e11d24 to
521927d
Compare
rafaelbsky
force-pushed
the
bsky-subscription-routes
branch
from
345cca1 to
49a80c1
Compare
rafaelbsky
force-pushed
the
bsky-subscription-dataplane
branch
from
521927d to
7670fe4
Compare
rafaelbsky
force-pushed
the
bsky-subscription-routes
branch
from
49a80c1 to
94fb72f
Compare
Base automatically changed from
bsky-subscription-dataplane
to
bsky-subscription-listener
December 2, 2024 20:11
rafaelbsky
force-pushed
the
bsky-subscription-listener
branch
from
0d1f067 to
3eb091e
Compare
rafaelbsky
force-pushed
the
bsky-subscription-routes
branch
from
94fb72f to
c00498c
Compare
dholms
reviewed
Dec 3, 2024
dholms
reviewed
Dec 3, 2024
dholms
reviewed
Dec 3, 2024
dholms
reviewed
Dec 3, 2024
| const { dids } = req | ||
|
|
||
| return { | ||
| subscriptionEntitlements: await db.db |
There was a problem hiding this comment.
we want to make sure these are returned in the same order as the params
and that the response as undefined as the array item that corresponds to each param that does not have entitlements
you can find similar logic in other dataplane routes such as in the relationships file
dholms
reviewed
Dec 3, 2024
dholms
reviewed
Dec 3, 2024
dholms
reviewed
Dec 3, 2024
|
Closing this as we'll make change the approach a bit to do some parts of it in bsync. Parts of this code will be used in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.