add email token normalization #3197
Open
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtoolz
force-pushed
the
main
branch
2 times, most recently
from
387d187 to
5626b48
Compare
use regex to normalize email tokens use token normalization function when generating tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds basic email token normalization. Basically, it just adds a tiny string normalization function
normalizeEmailTokento the email token verification pipelineI am suggesting this change because I encountered the following UX problem: I mistyped my token when verifying my email address by placing the hyphen in the incorrect position. Then, just out of curiosity, I just removed the hyphen all together, which didn't work either. This is obviously an insanely trivial problem, but a nice UX thing we have come to expect these days; my commitment to the advancement of human laziness is unwavering.