Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification filtering #3224

Closed
wants to merge 1 commit into from
Closed

Notification filtering #3224

wants to merge 1 commit into from

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Dec 10, 2024

No description provided.

gaearon
gaearon approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaearon gaearon mentioned this pull request Dec 10, 2024
Merged
@gaearon
Copy link
Contributor

gaearon commented Dec 10, 2024

rolled into #3222

@gaearon gaearon closed this Dec 10, 2024
@gaearon
Copy link
Contributor

gaearon commented Dec 11, 2024 •
edited
Loading

Seeing questions about what this is for — this is groundwork for adding a separate Mentions tab to the app. The only difference between Mentions and All is that Mentions would omit likes and follows (but it would show mentions, quotes, replies, and other notifications that contain text).

See bluesky-social/social-app#7044.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dholms @gaearon