-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add account details to queryStatuses #3236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthieusieben
commented
Dec 12, 2024
•
edited
Loading
edited
- Add support for pre-existing view indexes in the migration (allowing the views and indexes to be created manually instead of through the migration)
- Refresh materialized views from the worker (note: refresh order matters!)
- Determine which columns to expose as filter
- For those: add an index on their respective materialized views
- Adapt the code to support the filtering
3a88fb1
to
9401fc2
Compare
foysalit
reviewed
Dec 18, 2024
foysalit
reviewed
Dec 18, 2024
matthieusieben
commented
Dec 20, 2024
7bbec5a
to
3f7412c
Compare
d86cf08
to
da81bb8
Compare
dholms
reviewed
Jan 13, 2025
dholms
reviewed
Jan 13, 2025
packages/ozone/src/db/migrations/20241220T144630860Z-stats-materialized-views.ts
Outdated
Show resolved
Hide resolved
dholms
reviewed
Jan 13, 2025
dholms
reviewed
Jan 13, 2025
dholms
reviewed
Jan 13, 2025
foysalit
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
dholms
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.