✨ Add subject tags with report type #3260
Merged
+118
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foysalit
commented
Dec 18, 2024
| @@ -69,7 +69,7 @@ describe('report-muting', () => { | |||
| }) | |||
|
|
|||
| // Verify that a subject status was not created for bob's post since the reporter was muted | |||
| await assertSubjectStatus(bobsPostSubject.uri, undefined) | |||
| await assertSubjectStatus(bobsPostSubject.uri, REVIEWNONE) | |||
There was a problem hiding this comment.
This only needed changing because we are now emitting an additional tag event because of report which causes the status to change to reviewNone which is similar to not having a reviewstate so there is no functional change.
matthieusieben
approved these changes
Dec 18, 2024
| try { | ||
| const tags: string[] = [] | ||
| const tags = new Set([...initialTags]) |
There was a problem hiding this comment.
You don't need to copy here (the Set will do that for you). This also allows to type the argument in a broader way initialTags?: Iterable<string> instead of defaulting to an empty array.
Suggested change
| const tags = new Set([...initialTags]) | |
| const tags = new Set(initialTags) |
There was a problem hiding this comment.
cleaned it up as recommended!
| await tagService.evaluateForSubject() | ||
| const initialTags = isModEventReport(event) | ||
| ? [getTagForReport(event.reportType)] | ||
| : [] |
There was a problem hiding this comment.
Nit: No need to create empty unused array here.
Suggested change
| : [] | |
| : undefined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds report reason tags to subjects which enables moderators to filter queue items based on the subjects' report types.