✨ Add a policy property to takedown events #3271
Conversation
| "policy": { | ||
| "type": "string", | ||
| "description": "Name/Keyword of the policy that drove the decision." | ||
| } |
There was a problem hiding this comment.
Is there any merit to sprinkling this onto other event types such as modEventLabel?
There was a problem hiding this comment.
Labels themselves are quite descriptive of the "why" part of the action and confirmed from T&S folks that this won't be necessary any time soon.
| "policy": { | ||
| "type": "string", | ||
| "description": "If specified, only events where the policy matches the given policy are returned" | ||
| }, |
There was a problem hiding this comment.
Is there a decent chance we end-up wanting to list multiple policies here in the future? If so, we could proactively make this an array.
There was a problem hiding this comment.
T&S expressed that this may be nice to have at some point but not anytime soon. I'll get it in the backend but the UI side will mostly keep it 1:1
| ) { | ||
| eventView.event = { | ||
| ...eventView.event, | ||
| policy: event.meta.policy, | ||
| policies: event.meta.policies.split(' '), |
There was a problem hiding this comment.
Look out for the empty string, which likes to split into [''].
There was a problem hiding this comment.
In other words:
const policies = []
const serialized = policies.join(' ')
const deserialized = serialized.split(' ')
// we want policies and deserialized to both be `[]`
// but policies is `[]` while deserialized is `['']`There was a problem hiding this comment.
yep yep! nice catch. realized the separator is an issue to start with and ended up finding this too.
This PR adds an optional
policyproperty to all takedown events that allows an arbitrary string value and allows moderators to query for all takedowns by specifying apolicyparam through thqueryEventsendpoint.