Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subs 4] Fix purchase-related proto casing #3276

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

rafaelbsky
Copy link
Contributor

@rafaelbsky rafaelbsky commented Dec 20, 2024

I should have used snake case instead of camel case. Once I got to the Go dataplane implementation and tried to implement it there, it complained about the casing.

@rafaelbsky rafaelbsky changed the base branch from main to plus-lexicons December 20, 2024 00:35
@rafaelbsky rafaelbsky force-pushed the fix-bsync-proto-casing branch 3 times, most recently from b0688f0 to 88a05a9 Compare December 23, 2024 20:35
@rafaelbsky rafaelbsky changed the title Fix bsync proto casing Fix purchase-related proto casing Dec 23, 2024
@rafaelbsky rafaelbsky changed the title Fix purchase-related proto casing [subs 3] Fix purchase-related proto casing Jan 3, 2025
@rafaelbsky rafaelbsky changed the title [subs 3] Fix purchase-related proto casing [subs 4] Fix purchase-related proto casing Jan 3, 2025
@rafaelbsky rafaelbsky force-pushed the plus-lexicons branch 2 times, most recently from 4a8f5f7 to 94579c6 Compare January 3, 2025 15:54
Base automatically changed from plus-lexicons to subscriptions-backend January 3, 2025 16:00
@rafaelbsky rafaelbsky force-pushed the fix-bsync-proto-casing branch from 88a05a9 to 22204d1 Compare January 3, 2025 16:01
@rafaelbsky rafaelbsky merged commit a6a376b into subscriptions-backend Jan 3, 2025
10 checks passed
@rafaelbsky rafaelbsky deleted the fix-bsync-proto-casing branch January 3, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants