Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lex-cli: Fix TS Errors with codegen #3282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tcyrus
Copy link

@tcyrus tcyrus commented Dec 21, 2024

These are fixes for the TypeScript Errors (#3230) that I encountered with the lex-cli codegen output.

The specific changes are:

  • updated ts-morph to ^24.0.0
  • added isTypeOnly to named imports in codegen where relevant
  • use type only imports in lex-cli

The new codegen output should be functionally the same (if it was working before, it should still work). I tried to avoid making any breaking changes.

I'm already using this patched version of lex-cli for a personal project.

@tcyrus
Copy link
Author

tcyrus commented Jan 24, 2025

@matthieusieben sorry to poke, but I wanted to ask if there's anything blocking this from getting merged. I wanted to remove the patchfile from my repo as soon as possible.

@matthieusieben
Copy link
Contributor

We are working on a major upgrade of the api package. I'm waiting for it to be merged before I come back to this one. I'm keeping this on my radar, I promise !

@matthieusieben matthieusieben self-assigned this Jan 24, 2025
@tcyrus
Copy link
Author

tcyrus commented Jan 24, 2025

Gotcha. I'll remove the changes that are covered by your PR to make the merge conflicts a bit easier to deal with.

@tcyrus tcyrus closed this Feb 14, 2025
@tcyrus tcyrus reopened this Feb 14, 2025
@tcyrus
Copy link
Author

tcyrus commented Feb 14, 2025

I squashed everything to remove the merge commit.

There's a Windows issue that prevents me from building + testing the repo (details). I'll submit an Issue / PR for this one too.

I don't think I can resolve the "This branch must not contain merge commits." error from GitHub on my end. This is probably because there are merge commits that predate my PR in the branch that I can't remove.

@tcyrus tcyrus force-pushed the lex-cli-ts-fix branch 3 times, most recently from c8a40a3 to 09bf71c Compare February 15, 2025 17:29
@tcyrus
Copy link
Author

tcyrus commented Feb 15, 2025

Rebuilt the lockfile so PR can run

@tcyrus
Copy link
Author

tcyrus commented Feb 15, 2025

Fixed Lint Issue since that's the only thing failing for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants