Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDS host argument to blob export #884

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add PDS host argument to blob export #884

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55df0a7
feature: Added --pds-host argument to blob export
ngerakines Dec 19, 2024
b7bd2ee
refactor: Updating variables to follow convention
ngerakines Dec 19, 2024
39439f4
refactor: Removing env variable because it is a bit ambiguous
ngerakines Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cmd/goat/blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ var cmdBlob = &cli.Command{
Aliases: []string{"o"},
Usage: "directory to store blobs in",
},
&cli.StringFlag{
Name: "pds-host",
Usage: "URL of the PDS to export blobs from (overrides DID doc)",
EnvVars: []string{"ATP_PDS_HOST"},
ngerakines marked this conversation as resolved.
Show resolved Hide resolved
},
},
Action: runBlobExport,
},
Expand Down Expand Up @@ -73,9 +78,14 @@ func runBlobExport(cctx *cli.Context) error {
return err
}

pds_host := cctx.String("pds-host")
if pds_host == "" {
pds_host = ident.PDSEndpoint()
}

ngerakines marked this conversation as resolved.
Show resolved Hide resolved
// create a new API client to connect to the account's PDS
xrpcc := xrpc.Client{
Host: ident.PDSEndpoint(),
Host: pds_host,,
ngerakines marked this conversation as resolved.
Show resolved Hide resolved
}
if xrpcc.Host == "" {
return fmt.Errorf("no PDS endpoint for identity")
Expand Down