Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inductive firehose interop tests #963

Merged
merged 3 commits into from
Mar 4, 2025
Merged

inductive firehose interop tests #963

merged 3 commits into from
Mar 4, 2025

Conversation

bnewbold
Copy link
Collaborator

Pulls in the JSON-formatted MST inversion tests from @dholms's typescript implementation.

Updates the indigo:atproto/repo/mst code to include additional "proof" blocks for "create" record ops, not just "delete" record ops. I'm not sure the book is totally closed on that decision, but going to get this implemented and merged for now, so that implementation/interop (between typescript and golang) is not a barrier or issue in the protocol decision.

}

func LoadCommitProofFixtures(p string) []CommitProofFixture {
b, err := os.ReadFile(p)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

embed instead?

@bnewbold bnewbold merged commit c295912 into main Mar 4, 2025
9 checks passed
@bnewbold bnewbold deleted the bnewbold/inductive-tests branch March 4, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants