[Video] Remove hack from scrubber (#5063)

* remove mouseleave, add pointer cancel * don't show time indicator if duration is 0
bluesky-social · Sep 2, 2024 · 17d82a6 · 17d82a6
1 parent bf15fad
commit 17d82a6
Showing 1 changed file with 3 additions and 15 deletions.
diff --git a/src/view/com/util/post-embeds/VideoEmbedInner/VideoWebControls.tsx b/src/view/com/util/post-embeds/VideoEmbedInner/VideoWebControls.tsx
@@ -253,7 +253,7 @@ export function Controls({
         style={a.flex_1}
         onPress={onPressEmptySpace}
       />
-      {active && !showControls && !focused && (
+      {active && !showControls && !focused && duration > 0 && (
         <TimeIndicator time={Math.floor(duration - currentTime)} />
       )}
       <View
@@ -475,21 +475,8 @@ function Scrubber({
     if (isFirefox && scrubberActive) {
       document.body.classList.add('force-no-clicks')
 
-      const abortController = new AbortController()
-      const {signal} = abortController
-      document.documentElement.addEventListener(
-        'mouseleave',
-        () => {
-          isSeekingRef.current = false
-          onSeekEnd()
-          setScrubberActive(false)
-        },
-        {signal},
-      )
-
       return () => {
         document.body.classList.remove('force-no-clicks')
-        abortController.abort()
       }
     }
   }, [scrubberActive, onSeekEnd])
@@ -548,7 +535,8 @@ function Scrubber({
         }}
         onPointerDown={onPointerDown}
         onPointerMove={onPointerMove}
-        onPointerUp={onPointerUp}>
+        onPointerUp={onPointerUp}
+        onPointerCancel={onPointerUp}>
         <View
           style={[
             a.w_full,