Skip to content

Commit

Permalink
Alt text followups -- SLIGHTLY larger, and update gifs (#4252)
Browse files Browse the repository at this point in the history
* Bump up the alt text indicator's text size just a smidge

* Update the GIF alt indicator to match images (right side, visually smaller on mobile)
  • Loading branch information
pfrazee authored May 29, 2024
1 parent 19ee89c commit efdfb7f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/view/com/util/images/Gallery.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const styles = StyleSheet.create({
},
alt: {
color: 'white',
fontSize: 6,
fontSize: 7,
fontWeight: 'bold',
},
})
12 changes: 6 additions & 6 deletions src/view/com/util/post-embeds/GifEmbed.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {FontAwesomeIcon} from '@fortawesome/react-native-fontawesome'
import {msg, Trans} from '@lingui/macro'
import {useLingui} from '@lingui/react'

import {HITSLOP_10} from '#/lib/constants'
import {HITSLOP_20} from '#/lib/constants'
import {parseAltFromGIFDescription} from '#/lib/gif-alt-text'
import {isWeb} from '#/platform/detection'
import {EmbedPlayerParams} from 'lib/strings/embed-player'
Expand Down Expand Up @@ -166,7 +166,7 @@ function AltText({text}: {text: string}) {
accessibilityRole="button"
accessibilityLabel={_(msg`Show alt text`)}
accessibilityHint=""
hitSlop={HITSLOP_10}
hitSlop={HITSLOP_20}
onPress={control.open}
style={styles.altContainer}>
<Text style={styles.alt} accessible={false}>
Expand Down Expand Up @@ -195,18 +195,18 @@ const styles = StyleSheet.create({
altContainer: {
backgroundColor: 'rgba(0, 0, 0, 0.75)',
borderRadius: 6,
paddingHorizontal: 6,
paddingVertical: 3,
paddingHorizontal: isWeb ? 8 : 6,
paddingVertical: isWeb ? 6 : 3,
position: 'absolute',
// Related to margin/gap hack. This keeps the alt label in the same position
// on all platforms
left: isWeb ? 8 : 5,
right: isWeb ? 8 : 5,
bottom: isWeb ? 8 : 5,
zIndex: 2,
},
alt: {
color: 'white',
fontSize: 10,
fontSize: isWeb ? 10 : 7,
fontWeight: 'bold',
},
})
2 changes: 1 addition & 1 deletion src/view/com/util/post-embeds/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ const styles = StyleSheet.create({
},
alt: {
color: 'white',
fontSize: 6,
fontSize: 7,
fontWeight: 'bold',
},
customFeedOuter: {
Expand Down

0 comments on commit efdfb7f

Please sign in to comment.