bskyogcard: fix some express plumbing

bluesky-social · Jun 20, 2024 · f907aa5 · f907aa5
1 parent fab409a
commit f907aa5
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/bskyogcard/src/routes/util.ts b/bskyogcard/src/routes/util.ts
@@ -9,7 +9,6 @@ export const handler = (runHandler: Handler): RequestHandler => {
   return async (req, res, next) => {
     try {
       await runHandler(req, res)
-      next()
     } catch (err) {
       next(err)
     }
@@ -30,8 +29,8 @@ export function originVerifyMiddleware(ctx: AppContext): RequestHandler {
 
 export const errorHandler: ErrorRequestHandler = (err, req, res, next) => {
   httpLogger.error({err}, 'request error')
-  if (!res.headersSent) {
-    res.status(500).end('server error')
+  if (res.headersSent) {
+    return next(err)
   }
-  return next()
+  return res.status(500).end('server error')
 }