Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗺️ fix an issue where web devices that see the Drawer couldn't access Profile from said Drawer #1157

Closed
wants to merge 2 commits into from
Closed

🗺️ fix an issue where web devices that see the Drawer couldn't access Profile from said Drawer #1157

wants to merge 2 commits into from

Conversation

Kingles
Copy link
Contributor

@Kingles Kingles commented Aug 14, 2023 •
edited
Loading

Previously, when using the web and the viewport was smaller than 1230px, nothing would happen when the user clicked on the "Profile" option in the Drawer component. This fixes that!

  • Pulled over the screen props into FlatNavigator from the MyProfileTabNavigator directly above.
  • Added the appropriate type to FlatNavigatorParams
  • Kept the ts-ignore from before, as there still seems to be a type issue there.

@ansh ansh self-requested a review September 12, 2023 10:13
@ansh
Copy link
Contributor

ansh commented Sep 12, 2023

Thank you for creating this @Kingles !

There were a few changes that I needed to make to make everything work well. So, I had to create a new PR to wrap it up. Closing this in favor of that #1437

@ansh ansh closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh ansh Awaiting requested review from ansh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kingles @ansh