Language settings updates, new primary language setting #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oo nice! some nits on copy, open to feedback:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-855
We've noticed some confusion around languages settings. This PR attempts to alleviate some of this confusion by introducing a new setting called "Primary language", in addition to the existing "Content languages" setting.
For now, the primary language setting will only be used for generating translation links for Google Translate.
The existing content languages setting will continue to function as it has been; that is, it will help filter content in custom feeds you're subscribed to.
This PR moves both settings to a new screen/route, and adds a dropdown/select input that uses the default UX patterns of each platform. Note: we have minimal control over the styling of the dropdown on Android.
Screen.Recording.2023-09-18.at.4.48.59.PM.mov