Add tags support to app
#1524
Closed
Add tags support to app
#1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
force-pushed
the
eric/app-864-integrate-post-tags-into-app
branch
from
615ecec to
4b47380
Compare
(cherry picked from commit 3098ebb)
…e-post-tags-into-app * origin/main: (40 commits) 1.52 README: tweaks to high-level context (#1625) Fix stuck lightbox header after double tap (#1627) Fix: add padding to the spinner bottom while loading threads (#1626) Rewrite Android lightbox (#1624) Dont trim before posting (close #1621) (#1622) Only listen to back button on android (#1623) Improve typeahead search with inclusion of followed users (temporary solution) (#1612) Slightly smaller highlighted post text (#1608) Pull upstream bugfixes to bottom-sheet (#1606) Fix animations and gestures getting reset on state updates in the lightbox (#1618) Remove unused lightbox options (#1616) Profile UI tweaks (#1607) Fix invite codes flash on desktop, use loading placeholder (#1591) Update to [email protected] (#1599) Fixed a typo on the onboarding recommended screen (#1604) Onboarding & feed fixes (#1602) Improve time to content in the search page (#1603) Fix a potential reference error in bottombarweb (#1600) Fix: only use scroll-positioning control on thread when looking at replies (#1587) ...
…t-tags-into-app * origin: Fix bug that prevents unfollowing (#1633)
…t-tags-into-app * origin: Disable events on hidden bars (#1686) Fix profile layout shift (#1690) Don't re-render bars when showing/hiding them (#1691) Fix crash when scrolling down on the web (#1684) Make shell hide/show animation smoother (#1683) Fix layout shift for multi-image posts (#1673) bskyweb: add rate limiting to reduce DoSability use new zeed-dom version (#1671) 1.53
estrattonbailey
commented
Oct 19, 2023
estrattonbailey
commented
Oct 19, 2023
| @@ -211,6 +225,7 @@ export const ComposePost = observer(function ComposePost({ | |||
| onStateChange: setProcessingState, | |||
| knownHandles: autocompleteView.knownHandles, | |||
| langs: store.preferences.postLanguages, | |||
| tags, | |||
There was a problem hiding this comment.
Outline tags are posted to API here, inline are contained in the raw text and detected later
estrattonbailey
commented
Oct 19, 2023
| <View> | ||
| <TagInputEntryButton onRequestOpen={openSheet} tags={tags} /> | ||
|
|
||
| <Portal> |
There was a problem hiding this comment.
New portal component
estrattonbailey
commented
Oct 19, 2023
| @@ -94,17 +106,29 @@ export const TextInput = forwardRef(function TextInputImpl( | |||
| newRt.detectFacetsWithoutResolution() | |||
| setRichText(newRt) | |||
|
|
|||
| const prefix = getMentionAt( | |||
| const mentionPrefix = getMentionAt( | |||
There was a problem hiding this comment.
Copied this for tags, so renamed for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
@tiptap/suggestions, awaiting allow users to pass a customfindSuggestionMatchto Suggestion plugin ueberdosis/tiptap#4515