Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only prompt users once to verify email (according to local storage) #1658

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Only prompt users once to verify email (according to local storage) #1658

merged 1 commit into from
Oct 10, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Oct 10, 2023

Close #1657

We have it at once a week right now. In hindsight I think that was the wrong call, because some people simply won't want to verify and nagging them endlessly won't fix that. I'm going to modify it to ask once, and store than in device storage. That'll still lead to multiple prompts (switching devices, account storage clearing) but it'll be better.

Another downside to this approach to be aware of is that you won't get prompted when you create a second account. We'll ultimately want to move this server-side.

@pfrazee pfrazee merged commit bc2c44c into main Oct 10, 2023
4 checks passed
@pfrazee pfrazee deleted the 1657-reduce-prompts branch October 10, 2023 17:57
estrattonbailey added a commit that referenced this pull request Oct 11, 2023
@estrattonbailey
Merge remote-tracking branch 'origin' into eric/app-864-integrate-pos…
7a97c3c 
…t-tags-into-app

* origin: (21 commits)
  resolve fork of zeed-dom (#1663)
  Port remaining lightbox code to Reanimated (#1669)
  Update testrunner to use new dev-env [WIP] (#1575)
  Fix MobX crash for Android lightbox (#1668)
  Change lightbox to use Pager (#1666)
  make empty feed required (#1667)
  Only warn on links to bsky.app if it represents itself as another url (#1662)
  Fix keyboard double pad issue in email change & verify modals (#1664)
  Don't highlight tags in composer yet (#1665)
  Fix: fetch follows on desktop search for typeahead (#1660)
  Remove duplicate modal container (#1661)
  Drive-by lightbox refactors (#1659)
  Only prompt users once to verify email (according to local storage) close #1657 (#1658)
  Revert "Fix invite codes flash on desktop, use loading placeholder (#1591)" (#1656)
  Refactor iOS lightbox to Reanimated (#1645)
  Bump package.json to 1.52
  Remove unnecessary opacity logic (#1646)
  Fix typo in image.ts (#1638)
  fix typo README.md (#1631)
  Typo fix in README.md: "small about" -> "small amount" (#1639)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APP-887] Users are getting prompted to verify email too often
2 participants
@pfrazee @gaearon