Lists updates: curate lists and blocklists #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrazee
force-pushed
the
lists-updates
branch
from
a96b96a to
72f9468
Compare
…erators and lists
pfrazee
force-pushed
the
lists-updates
branch
from
7355dbb to
c104dba
Compare
pfrazee
changed the title
Comment on lines
+123
to
+128
| list.cacheAddMember(profile) | ||
| } | ||
| }, | ||
| onRemove(listUri: string) { | ||
| if (listUri === list.uri) { | ||
| list.cacheRemoveMember(profile) |
There was a problem hiding this comment.
Can these optimistic updates happen in the actual add/remove methods? Just feels odd to have them over here separate.
There was a problem hiding this comment.
That modal uses a different set of ListModels that aren't shared by the one showing the user, unfortunately
|
|
||
| const onPressAvi = React.useCallback(() => { | ||
| if ( | ||
| avatar // TODO && !(view.moderation.avatar.blur && view.moderation.avatar.noOverride) |
There was a problem hiding this comment.
yeah we'll come back to it when mod labels get added to lists or feeds
estrattonbailey
approved these changes
Nov 1, 2023
Co-authored-by: Eric Bailey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Technical updates:
Tabscomponent for creating tabbed interfaces with headersStill todo:
Moderation labels on listsblocked by backend, filed an issue