Scope drawer drag workaround to feed pagers #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Oct 13, 2023
| @@ -30,13 +30,13 @@ index ab0fc7f..fbbf19f 100644 | |||
| if (self.reactViewController.navigationController != nil && self.reactViewController.navigationController.interactivePopGestureRecognizer != nil) { | |||
| [self.scrollView.panGestureRecognizer requireGestureRecognizerToFail:self.reactViewController.navigationController.interactivePopGestureRecognizer]; | |||
| } | |||
| @@ -463,4 +467,21 @@ | |||
| @@ -463,4 +467,21 @@ - (NSString *)determineScrollDirection:(UIScrollView *)scrollView { | |||
There was a problem hiding this comment.
idk why my git decided to add these but ok
gaearon
commented
Oct 13, 2023
| - (BOOL)isLtrLayout { | ||
| return [_layoutDirection isEqualToString:@"ltr"]; | ||
| } | ||
| + | ||
| +- (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:(UIGestureRecognizer *)otherGestureRecognizer { | ||
| + if (otherGestureRecognizer == self.scrollView.panGestureRecognizer) { | ||
| + if (!_overdrag && otherGestureRecognizer == self.scrollView.panGestureRecognizer) { |
There was a problem hiding this comment.
if (!_overdrag && is the actual change here
|
@gaearon would you mind adding this fix into https://github.com/callstack/react-native-pager-view? |
|
This isn't really a fix tbh, more of a hack for our case. I'm not sure what a proper fix would be since it depends on how your drawer works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a patch that makes the drawer gesture coexist with feed pagers. However, this patch breaks the overdrag in iOS lightbox. We want to enable this patch only for feed pagers. We could've introduced a prop for this, but conceptually, we really just want to disable the hack when overdrag is on (because it breaks overdrag, and feed pagers don't use overdrag).
By default it's
false. We only turn it on for the lightbox right now. So this fixes the lightbox.This does that.
Test plan
You'd need to
yarn prebuildto get the new behavior.