Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Metro handle import/export instead of Babel #1772

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Let Metro handle import/export instead of Babel #1772

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
799c4a9
Let Metro handle import/export instead of Babel
gaearon Oct 30, 2023
adae808
Keep using Babel for ESM->CJS in tests
gaearon Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ module.exports = function (api) {
'babel-preset-expo',
{
lazyImports: true,
native: {
disableImportExportTransform: true,
},
},
],
],
Expand Down
10 changes: 10 additions & 0 deletions metro.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,17 @@ cfg.resolver.sourceExts = process.env.RN_SRC_EXT

cfg.transformer.getTransformOptions = async () => ({
transform: {
experimentalImportSupport: true,
inlineRequires: true,
nonInlinedRequires: [
// We can remove this option and rely on the default after
// https://github.com/facebook/metro/pull/1126 is released.
'React',
'react',
'react/jsx-dev-runtime',
'react/jsx-runtime',
'react-native',
],
},
})

Expand Down