Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sentry only for errors #1776

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Use Sentry only for errors #1776

merged 3 commits into from
Nov 7, 2023

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 31, 2023

Sentry has a bunch of fancy tracing features that we're not using.
To keep things simple, let's just disable them.

@gaearon gaearon requested review from pfrazee and ansh October 31, 2023 04:24
@pfrazee
Copy link
Collaborator

pfrazee commented Nov 2, 2023

@ansh this look okay to you?

@ansh
Copy link
Contributor

ansh commented Nov 5, 2023

@pfrazee Yeah this is fine.

We can use those Sentry features when sentry-expo implements them.

@gaearon gaearon merged commit fa82194 into main Nov 7, 2023
4 checks passed
@gaearon gaearon deleted the less-sentry branch November 7, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh ansh ansh approved these changes

@pfrazee pfrazee Awaiting requested review from pfrazee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @pfrazee @ansh