Remove unused Intl.Segmenter polyfill #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrazee
approved these changes
Nov 1, 2023
gaearon
commented
Nov 1, 2023
| // loading emoji mart data | ||
| // TODO: This condition doesn't make sense; emojimart has nothing to do with Intl. |
There was a problem hiding this comment.
Accidentally noticed this. I presume it was added without looking at the condition above. What's happening here is bizarre:
- Emojimart data is undefined in local development (because the condition never triggers) but the emoji picker somehow works. (Is data not required??)
- In production, emojimart data is defined, but it's only because our
scripts.htmlpartial template adds a<script>tag for the thing that triggers emojimart data loading anyway. So this code isn't necessary.
I'd remove it now but I want to understand why it works without data locally. So for now, not touching this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #718.
The
graphemerdep andIntlpolyfill were originally added in 1b93986 for composer (4549893).However,
@atproto/apino longer usesIntland instead usesgraphemerdirectly: bluesky-social/atproto#1044. So there is no need for these.Test Plan
Verified composer works on iOS, Android, and web (Chrome and FF).